nastra commented on code in PR #11254:
URL: https://github.com/apache/iceberg/pull/11254#discussion_r1800592740
##########
core/src/main/java/org/apache/iceberg/SnapshotProducer.java:
##########
@@ -595,20 +596,20 @@ private List<ManifestFile> writeDataFileGroup(
}
protected List<ManifestFile> writeDeleteManifests(
- Collection<DeleteFileHolder> files, PartitionSpec spec) {
+ Collection<DeleteFile> files, PartitionSpec spec) {
return writeManifests(files, group -> writeDeleteFileGroup(group, spec));
}
private List<ManifestFile> writeDeleteFileGroup(
- Collection<DeleteFileHolder> files, PartitionSpec spec) {
+ Collection<DeleteFile> files, PartitionSpec spec) {
RollingManifestWriter<DeleteFile> writer =
newRollingDeleteManifestWriter(spec);
try (RollingManifestWriter<DeleteFile> closableWriter = writer) {
- for (DeleteFileHolder file : files) {
Review Comment:
I think that makes sense to me. Even if the current code only passes
`PendingDeleteFile` it's possible that someone accidentally passes a normal
`DeleteFile` in the future. I've added a precondition check here, but I don't
think it's currently easily testable with a unit test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
