aokolnychyi commented on code in PR #11254:
URL: https://github.com/apache/iceberg/pull/11254#discussion_r1801592765
##########
core/src/main/java/org/apache/iceberg/SnapshotProducer.java:
##########
@@ -595,20 +596,22 @@ private List<ManifestFile> writeDataFileGroup(
}
protected List<ManifestFile> writeDeleteManifests(
- Collection<DeleteFileHolder> files, PartitionSpec spec) {
+ Collection<DeleteFile> files, PartitionSpec spec) {
return writeManifests(files, group -> writeDeleteFileGroup(group, spec));
}
private List<ManifestFile> writeDeleteFileGroup(
- Collection<DeleteFileHolder> files, PartitionSpec spec) {
+ Collection<DeleteFile> files, PartitionSpec spec) {
RollingManifestWriter<DeleteFile> writer =
newRollingDeleteManifestWriter(spec);
try (RollingManifestWriter<DeleteFile> closableWriter = writer) {
- for (DeleteFileHolder file : files) {
+ for (DeleteFile file : files) {
+ Preconditions.checkState(
Review Comment:
Question: Should we use `checkState` or `checkArgument`? Also, any chance we
can shorten the error message to stay on 1 line?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
