nastra commented on code in PR #11158:
URL: https://github.com/apache/iceberg/pull/11158#discussion_r1793354776
##########
core/src/main/java/org/apache/iceberg/ManifestFilterManager.java:
##########
@@ -230,27 +232,20 @@ SnapshotSummary.Builder
buildSummary(Iterable<ManifestFile> manifests) {
*
* @param manifests a set of filtered manifests
*/
- @SuppressWarnings("CollectionUndefinedEquality")
private void validateRequiredDeletes(ManifestFile... manifests) {
if (failMissingDeletePaths) {
- CharSequenceSet deletedFiles = deletedFiles(manifests);
- ValidationException.check(
- deletedFiles.containsAll(deletePaths),
- "Missing required files to delete: %s",
- COMMA.join(Iterables.filter(deletePaths, path ->
!deletedFiles.contains(path))));
+ deletedFiles(manifests).validateRequiredDeletes(filesToDelete);
Review Comment:
good catch, I was relying on existing tests to catch this but after your
comment I realized that there's no test coverage for this available. I added
test coverage and fixed this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
