nastra commented on code in PR #11158:
URL: https://github.com/apache/iceberg/pull/11158#discussion_r1793359976
##########
core/src/main/java/org/apache/iceberg/ManifestFilterManager.java:
##########
@@ -372,8 +367,14 @@ private boolean manifestHasDeletedFiles(
for (ManifestEntry<F> entry : reader.liveEntries()) {
F file = entry.file();
+
+ // add path-based delete to set of files to be deleted
+ if (deletePaths.contains(CharSequenceWrapper.wrap(file.path()))) {
Review Comment:
my goal was to reduce handling of paths vs files in a bunch of places and
only deal with actual files and also reduce required error handling in
`validateRequiredDeletes()` but as you mentioned in another comment this misses
the case when a path-based delete is performed with a non-existing file and
there wasn't any test coverage for this. I've added test coverage and rewrote
this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
