nastra commented on code in PR #11158:
URL: https://github.com/apache/iceberg/pull/11158#discussion_r1793462877
##########
core/src/main/java/org/apache/iceberg/ManifestFilterManager.java:
##########
@@ -533,4 +531,51 @@ private Pair<InclusiveMetricsEvaluator,
StrictMetricsEvaluator> metricsEvaluator
return metricsEvaluators.get(partition);
}
}
+
+ private class FilesToDeleteHolder {
Review Comment:
I'm also not a big fan of having `FilesToDeleteHolder` and it was just an
experiment to see how the changes would look, but it is indeed probably better
to have an abstract `Set<F> newFileSet()` method. I've refactored the code and
it should look cleaner now, thanks for the suggestion
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
