aokolnychyi commented on code in PR #11158:
URL: https://github.com/apache/iceberg/pull/11158#discussion_r1799824634
##########
core/src/main/java/org/apache/iceberg/ManifestFilterManager.java:
##########
@@ -71,9 +70,9 @@ public String partition() {
private final PartitionSet deleteFilePartitions;
private final PartitionSet dropPartitions;
private final CharSequenceSet deletePaths = CharSequenceSet.empty();
+ private final Set<F> deleteFiles = newFileSet();
Review Comment:
Can we co-locate `deleteFiles` and `deleteFilePartitions` as
`deleteFilePartitions` essentially contains a set of partitions derived from
`deleteFiles`.
##########
hive-metastore/src/test/java/org/apache/iceberg/hive/HiveTableTest.java:
##########
@@ -213,7 +213,7 @@ public void testDropTable() throws IOException {
table.newAppend().appendFile(file1).appendFile(file2).commit();
// delete file2
- table.newDelete().deleteFile(file2.path()).commit();
+ table.newDelete().deleteFile(file2).commit();
Review Comment:
Is this change required? There should be no behavior change, right?
##########
nessie/src/test/java/org/apache/iceberg/nessie/TestNessieTable.java:
##########
@@ -407,7 +407,7 @@ public void testDropTable() throws IOException {
table.newAppend().appendFile(file1).appendFile(file2).commit();
// delete file2
- table.newDelete().deleteFile(file2.path()).commit();
Review Comment:
Same question here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
