nastra commented on code in PR #11158:
URL: https://github.com/apache/iceberg/pull/11158#discussion_r1800532477
##########
hive-metastore/src/test/java/org/apache/iceberg/hive/HiveTableTest.java:
##########
@@ -213,7 +213,7 @@ public void testDropTable() throws IOException {
table.newAppend().appendFile(file1).appendFile(file2).commit();
// delete file2
- table.newDelete().deleteFile(file2.path()).commit();
+ table.newDelete().deleteFile(file2).commit();
Review Comment:
it's not a required change, but I wanted to move existing places to the
non-path-based delete path
##########
nessie/src/test/java/org/apache/iceberg/nessie/TestNessieTable.java:
##########
@@ -407,7 +407,7 @@ public void testDropTable() throws IOException {
table.newAppend().appendFile(file1).appendFile(file2).commit();
// delete file2
- table.newDelete().deleteFile(file2.path()).commit();
Review Comment:
it's not a required change, but I wanted to move existing places to the
non-path-based delete path
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
