nastra commented on code in PR #11158: URL: https://github.com/apache/iceberg/pull/11158#discussion_r1793063470
########## core/src/main/java/org/apache/iceberg/ManifestFilterManager.java: ########## @@ -71,6 +72,7 @@ public String partition() { private final PartitionSet deleteFilePartitions; private final PartitionSet dropPartitions; private final CharSequenceSet deletePaths = CharSequenceSet.empty(); + private final FilesToDeleteHolder filesToDelete = new FilesToDeleteHolder(); Review Comment: as discussed on Slack last week I renamed this class to `PendingDeleteFile` which implements `DeleteFile` (I just didn't want to make this PR too large). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org