aokolnychyi commented on code in PR #11158:
URL: https://github.com/apache/iceberg/pull/11158#discussion_r1792836843
##########
core/src/main/java/org/apache/iceberg/ManifestFilterManager.java:
##########
@@ -372,8 +367,14 @@ private boolean manifestHasDeletedFiles(
for (ManifestEntry<F> entry : reader.liveEntries()) {
F file = entry.file();
+
+ // add path-based delete to set of files to be deleted
+ if (deletePaths.contains(CharSequenceWrapper.wrap(file.path()))) {
Review Comment:
Why do we actually add the file to the set? I worry that it becomes
indistinguishable after that. I feel it would be more obvious to keep checking
`deletePaths.contains(file.path())` in addition to checking the file set. If
this is done purely to validate missing paths, I think it won't be enough.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
