aokolnychyi commented on code in PR #11158:
URL: https://github.com/apache/iceberg/pull/11158#discussion_r1792834057
##########
core/src/main/java/org/apache/iceberg/ManifestFilterManager.java:
##########
@@ -71,6 +72,7 @@ public String partition() {
private final PartitionSet deleteFilePartitions;
private final PartitionSet dropPartitions;
private final CharSequenceSet deletePaths = CharSequenceSet.empty();
+ private final FilesToDeleteHolder filesToDelete = new FilesToDeleteHolder();
Review Comment:
I'd consider calling it `Set<F> deleteFiles` to follow the existing naming
convention:
```
deleteFilePartitions -> a set of partitions of all files marked for deletion
deletePaths -> a set of paths to remove
deleteExpression -> an expression
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
