flyrain commented on code in PR #9839:
URL: https://github.com/apache/iceberg/pull/9839#discussion_r1517030350
##########
core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java:
##########
@@ -178,15 +178,18 @@ public void initialize(String name, Map<String, String>
unresolved) {
ConfigResponse config;
OAuthTokenResponse authResponse;
String credential = props.get(OAuth2Properties.CREDENTIAL);
+ // CONSIDER : putting scope in optional param map - reduce wiring on scope
Review Comment:
Looking a bit more. The second option(putting the `scope` into the optional
params) also needs to deprecate several methods, e.g., `exchangeToken()`,
`fetchToken()`, etc, since their signatures will change. I think it's not
worthy to do that now given that we will refactor later to use a
`OAuthClientCredentialsRequest` object. Let's move forward with this approach.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
