himadripal commented on PR #9839:
URL: https://github.com/apache/iceberg/pull/9839#issuecomment-1971845270
Although the issue discusses about making `audience` configurable but there
are few other optional parameter exists in the specification (I have added
support for `resource` as an additional example) which are not configurable
right now. This is an attempt to make all optional OAuth params passing
configurable. Have introduced a map instead of single param. Idea is if you
have those optional parameters configured in properties, we build map out of
it, picking only optional params from the properties and pass it along.
`scope` is also an optional parameter, I think it can also be moved to using
this map.
@nastra @rdblue @syun64 Please take a look and provide feedback.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
