himadripal commented on code in PR #9839:
URL: https://github.com/apache/iceberg/pull/9839#discussion_r1514955976
##########
aws/src/main/java/org/apache/iceberg/aws/s3/signer/S3V4RestSignerClient.java:
##########
@@ -207,7 +212,13 @@ private AuthSession authSession() {
token,
expiresAtMillis(properties()),
new AuthSession(
- ImmutableMap.of(), token, null, credential(), SCOPE,
oauth2ServerUri())));
+ ImmutableMap.of(),
+ token,
+ null,
+ credential(),
+ SCOPE,
+ oauth2ServerUri(),
+ optionalOAuthParams())));
Review Comment:
one in line 231, do not have token provided (token = null), we can still
create a private method with token as param, but this one looks for readable.
WDYT?
##########
aws/src/main/java/org/apache/iceberg/aws/s3/signer/S3V4RestSignerClient.java:
##########
@@ -207,7 +212,13 @@ private AuthSession authSession() {
token,
expiresAtMillis(properties()),
new AuthSession(
- ImmutableMap.of(), token, null, credential(), SCOPE,
oauth2ServerUri())));
+ ImmutableMap.of(),
+ token,
+ null,
+ credential(),
+ SCOPE,
+ oauth2ServerUri(),
+ optionalOAuthParams())));
Review Comment:
one in line 231, do not have token provided (token = null), we can still
create a private method with token as param, but this one looks more readable.
WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
