syun64 commented on code in PR #8976:
URL: https://github.com/apache/iceberg/pull/8976#discussion_r1473467310
##########
core/src/test/java/org/apache/iceberg/rest/RESTCatalogAdapter.java:
##########
@@ -105,6 +105,8 @@ enum HTTPMethod {
enum Route {
TOKENS(HTTPMethod.POST, "v1/oauth/tokens", null, OAuthTokenResponse.class),
+ SEPARATE_AUTH_TOKENS_URI(
Review Comment:
That makes sense @danielcweeks . I'm lacking the context on what that other
purpose is, since it's a class that's implemented and used within the test
suite just by looking at the code base...
Would it make sense to check the responseType to see if it is of
OAuthTokenResponse.class type in the default case instead? This means that any
POST request on the RestCatalogAdapter that has OAuthTokenResponse.class as the
responseType will be interpreted as an OAuth2 request to an external uri
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
