danielcweeks commented on code in PR #8976:
URL: https://github.com/apache/iceberg/pull/8976#discussion_r1493066567
##########
core/src/main/java/org/apache/iceberg/rest/HTTPClient.java:
##########
@@ -204,17 +204,28 @@ private static void throwFailure(
throw new RESTException("Unhandled error: %s", errorResponse);
}
+ private String buildPath(String path) {
Review Comment:
This is looking a lot cleaner now. However, we've now reduced this to a
single call in execute where we chain `buildUri(buildPath(path)`. This can
just be collapsed to a single method since they're both private and only called
in one spot.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
