danielcweeks commented on code in PR #8976:
URL: https://github.com/apache/iceberg/pull/8976#discussion_r1473314309
##########
core/src/main/java/org/apache/iceberg/rest/HTTPClient.java:
##########
@@ -314,7 +323,7 @@ private <T> T execute(
@Override
public void head(String path, Map<String, String> headers,
Consumer<ErrorResponse> errorHandler) {
- execute(Method.HEAD, path, null, null, null, headers, errorHandler);
+ execute(Method.HEAD, buildBaseUri(path), null, null, null, headers,
errorHandler);
Review Comment:
I don't follow why we're updating all of these methods since the all
delegate to the execute method. This feels unnecessary and should just be
handled in the execute method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
