syun64 commented on code in PR #8976:
URL: https://github.com/apache/iceberg/pull/8976#discussion_r1477366640
##########
core/src/main/java/org/apache/iceberg/rest/auth/OAuth2Util.java:
##########
@@ -361,6 +392,23 @@ public static class AuthSession {
private final String credential;
private final String scope;
private volatile boolean keepRefreshed = true;
+ private final String oauth2ServerUri;
+
+ public AuthSession(
+ Map<String, String> baseHeaders,
+ String token,
+ String tokenType,
+ String credential,
+ String scope,
+ String oauth2ServerUri) {
+ this.headers = RESTUtil.merge(baseHeaders, authHeaders(token));
+ this.token = token;
+ this.tokenType = tokenType;
+ this.expiresAtMillis = OAuth2Util.expiresAtMillis(token);
+ this.credential = credential;
+ this.scope = scope;
+ this.oauth2ServerUri = oauth2ServerUri;
+ }
public AuthSession(
Review Comment:
I noticed that too. I lack the context to make that decision, so I will
leave this comment thread for others to opine
##########
core/src/main/java/org/apache/iceberg/rest/auth/OAuth2Util.java:
##########
@@ -134,7 +134,8 @@ private static OAuthTokenResponse refreshToken(
Map<String, String> headers,
String subjectToken,
String subjectTokenType,
- String scope) {
+ String scope,
+ String oauth2ServerUri) {
Review Comment:
That's good insight @flyrain . However, I'm inclined to keep this here along
with the other token access related methods like "exchangeToken" and
"fetchToken" in the top level class OAuth2Util for simplicity.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
