syun64 commented on code in PR #8976: URL: https://github.com/apache/iceberg/pull/8976#discussion_r1480757774
########## core/src/main/java/org/apache/iceberg/rest/auth/OAuth2Properties.java: ########## @@ -27,6 +27,9 @@ private OAuth2Properties() {} /** A credential to exchange for a token in the OAuth2 client credentials flow. */ public static final String CREDENTIAL = "credential"; + /** Token endpoint URI to fetch token from if the Rest Catalog is not the authorization server. */ Review Comment: I think token endpoint is also correct here. What we refer to as OAuth Server URI is actually the token endpoint of the Auth server. https://swagger.io/docs/specification/authentication/openid-connect-discovery/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org