danielcweeks commented on code in PR #8976:
URL: https://github.com/apache/iceberg/pull/8976#discussion_r1473311127
##########
core/src/main/java/org/apache/iceberg/rest/HTTPClient.java:
##########
@@ -217,22 +230,22 @@ private URI buildUri(String path, Map<String, String>
params) {
*/
private <T> T execute(
Method method,
- String path,
+ String baseUri,
Review Comment:
I don't think we should be changing the parameter names here. This is still
the path, it's just that it can be a full path as opposed to a relative path.
I don't feel `baseUri` makes sense in this context.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
