nk1506 commented on code in PR #8907:
URL: https://github.com/apache/iceberg/pull/8907#discussion_r1414247701
##########
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java:
##########
@@ -162,8 +163,11 @@ protected void doRefresh() {
Thread.currentThread().interrupt();
throw new RuntimeException("Interrupted during refresh", e);
}
-
- refreshFromMetadataLocation(metadataLocation, metadataRefreshMaxRetries);
+ if (table != null &&
table.getTableType().equalsIgnoreCase(TableType.VIRTUAL_VIEW.name())) {
+ disableRefresh();
Review Comment:
If we are avoiding refresh and throwing any exception here, one of the
followings can be done:
1. Add the same errors to the corresponding tests something similar was
tried at previous
[commits](https://github.com/apache/iceberg/commit/477c7d1c24526e2983462c8fdd1f418264441aac#diff-9c8b69f86aec86aea82cd6675c1c24267d9a9d77d7715c2c792934cb954b328bR371).
2. Or Implement the same tests for HiveCatalog with its own error.
3. Or make all the Catalog consistent with error handling for such cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
