rdblue commented on code in PR #8907: URL: https://github.com/apache/iceberg/pull/8907#discussion_r1414717796
########## hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java: ########## @@ -168,6 +154,11 @@ public String name() { return name; } + @Override + public boolean tableExists(TableIdentifier identifier) { + return HiveCatalogUtil.isTableWithTypeExists(clients, identifier, TableType.EXTERNAL_TABLE); Review Comment: Is this an Iceberg requirement? It seems like this is more strict than we have been before. `HiveOperationsBase.validateTableIsIceberg` only requires `table_type` is `iceberg` (ignoring case). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org