rdblue commented on code in PR #8907:
URL: https://github.com/apache/iceberg/pull/8907#discussion_r1414720444
##########
core/src/main/java/org/apache/iceberg/BaseMetastoreTableOperations.java:
##########
@@ -307,24 +308,48 @@ protected enum CommitStatus {
* @param newMetadataLocation the path of the new commit file
* @param config metadata to use for configuration
* @return Commit Status of Success, Failure or Unknown
+ * @deprecated since 1.5.0, use {@link
BaseMetastoreTableOperations#checkCommitStatus(String,
+ * String, Map, Function)} instead.
*/
+ @Deprecated
Review Comment:
There's no need to deprecate this method and create a public method in its
place. It introduces unnecessary changes in other catalogs only to have the
same call pattern everywhere.
If you want to use the logic elsewhere, then the new public method shouldn't
live here. I recommend creating a static util method somewhere else.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
