Allon Mureinik has posted comments on this change.
Change subject: tools: engine-config need to remove all ver 2.2 values
......................................................................
Patch Set 5: (3 inline comments)
some /minor/ comment inline
....................................................
File backend/manager/dbscripts/common_sp.sql
Line 99: END; $procedure$
Line 100: LANGUAGE plpgsql;
Line 101:
Line 102: -- Deletes keys from action_version_map for the given versions (if
exists)
Line 103: create or replace FUNCTION fn_db_delete_version_map(v_cluster_version
varchar(10), v_sp_version varchar(40))
shouldn't this function be defined in action_version_map.sp?
Line 104: returns void
Line 105: AS $procedure$
Line 106: begin
Line 107: if (exists (select 1 from action_version_map where
cluster_minimal_version = v_cluster_version and storage_pool_minimal_version =
v_sp_version)) then
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ConnectAllHostsToLunCommand.java
Line 136: resultMap.put(lun.getLUN_id(), hosts);
Line 137: }
Line 138: hosts.add(vds.getId());
Line 139: }
Line 140: }
please return the comment "// Refresh all connected luns to host" - it is still
relevant.
Line 141: if (!validateConnectedLuns(vds,
getParameters().getLunIds())) {
Line 142: return new Pair<Boolean, Map<String,
List<Guid>>>(Boolean.FALSE, resultMap);
Line 143: }
Line 144: }
Line 141: if (!validateConnectedLuns(vds,
getParameters().getLunIds())) {
Line 142: return new Pair<Boolean, Map<String,
List<Guid>>>(Boolean.FALSE, resultMap);
Line 143: }
Line 144: }
Line 145: return new Pair<Boolean, Map<String,
List<Guid>>>(Boolean.TRUE, resultMap);
This if statement can be compacted to
return new Pair<Boolean, Map<String, List<Guid>>>(validateConnectedLuns(vds,
getParameters().getLunIds()), resultMap);
Line 146: }
Line 147:
Line 148: private boolean connectStorageToLunByVdsId(VDS vds, LUNs lun) {
Line 149: try {
--
To view, visit http://gerrit.ovirt.org/9131
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I08cccaa4724ae84785fa0f3d5ea4141626c0f575
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Livnat Peer <lp...@redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
