Yair Zaslavsky has posted comments on this change.

Change subject: tools: engine-config need to remove all ver 2.2 values
......................................................................


Patch Set 2:

Livnat,
Regarding MaxNumOfCpuPerSocket - can't this value change in time (i.e - future 
version).
IMHO, our config infra lacks the ability to define that a certain value will 
not change from version X till "end of times" (and besides, can we really 
decide such a thing? :) )
I think the conservative approach will be to cleanup in cases of boolean 
fields, where they mark that a feature did not exist until version 3.0.

--
To view, visit http://gerrit.ovirt.org/9131
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I08cccaa4724ae84785fa0f3d5ea4141626c0f575
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Livnat Peer <lp...@redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to