Livnat Peer has posted comments on this change. Change subject: tools: engine-config need to remove all ver 2.2 values ......................................................................
Patch Set 2: Yair, I don't think we can 'assure' anything. I also don't think that the fact that a config value had multiple values in previous versions means that it has higher probability than any other config to have multiple values in a future version. Making the decision if to eliminate the value from the config or keeping a general entry depends on the key itself. If there is an intererst to have this as a config because the user can change it or because it is a constant we don't want to keep in code then make it a general entry, if the only reason for having it in the config from the first place was different values for different versions you can remove it all together. Please note that my original comment was not about removing the config keys from the config values but to hold a single general entry for it. If instead we can eliminate the config all together - much better I am sure Allon and Kublin would love to see some more code go away :) -- To view, visit http://gerrit.ovirt.org/9131 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I08cccaa4724ae84785fa0f3d5ea4141626c0f575 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Livnat Peer <lp...@redhat.com> Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
