Maor Lipchuk has posted comments on this change. Change subject: engine:VM with remaining disks will not be deleted.(#822051) ......................................................................
Patch Set 5: (4 inline comments) comments are replied in the patch. I don't understand why only update for disks will reduce performence compared to deletes of users networks and Lun disks which are being done at the same way. .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmCommand.java Line 32: private boolean hasImages; Still, think it is more readable. Line 224: // Get all disk images for VM (VM should not have any image disk associated with it). I didn't follow you, what query are you talking about? As I wrote before it is not related to failure or success of tasks, the disks which I'm filtering are disks which didn't initiate any tasks because VDSM was not responsinve Line 233: imagesLeftInVm = true; Same as I wrote before, it is the same transaction logic we use when we delete LUN disks, why doing this that way and other operation differently. Just want to make sure that is being done in a unify way. Line 239: } Yes VM will be left with those two remained disks with ILLEGAL. User can now remove the VM again with those disks. This is a suggestion for the bug, if you think of a another solution for this bug, I will be happy if you can share it. -- To view, visit http://gerrit.ovirt.org/5806 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic59918037a87a2c169c4410d297de81a03ab6848 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Ayal Baron <aba...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
