Michael Kublin has posted comments on this change. Change subject: engine:VM with remaining disks will not be deleted.(#822051) ......................................................................
Patch Set 5: I would prefer that you didn't submit this (4 inline comments) The following patch will reduced performance at EndVmCommand with out any reason .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmCommand.java Line 32: private boolean hasImages; remove false, no reason Line 224: // Get all disk images for VM (VM should not have any image disk associated with it). You don't need that query, you know if you came here from EndWithFailure or from EndSuccessfully. I wrote these before Line 233: imagesLeftInVm = true; Transaction, why we need one transaction - these is a question which was asked by Maor. Maor, really u don't know why we want to unify related db operation at the same transaction. Line 239: } Also, I don't understand how these will help and will solve a bug? I have vm with 4 disks, one was removed successfully, one failed, two other disk I even did not start to remove and they are ok, but was marked as ILLEGAL. I have vm with which I can not do anything. The garbage image is left at vdsm and removed from our DB, but garbage vm is left at our db -- To view, visit http://gerrit.ovirt.org/5806 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic59918037a87a2c169c4410d297de81a03ab6848 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Ayal Baron <aba...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
