Maor Lipchuk has posted comments on this change. Change subject: engine:Delete image should roll forward.(#822051) ......................................................................
Patch Set 1: (1 inline comment) I think the appropriate solution would be that if disks was not able to delete we should leave the VM and change the disks statuses to ILLEGAL. I will introduce a new patch with this solution. .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveImageCommand.java Line 52: Because then the disk will still be in DB and reflected in the Disk tab, although it will not have any VM related to it. If the disk has snapshot it could cause a bug. I think that the appropriate solution would be that if disks was not able to delete we should leave the VM and change the disks statuses to ILLEGAL. I will introduce a new patch with this solution. -- To view, visit http://gerrit.ovirt.org/5806 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic59918037a87a2c169c4410d297de81a03ab6848 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Ayal Baron <aba...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
