Maor Lipchuk has posted comments on this change. Change subject: engine:VM with remaining disks will not be deleted.(#822051) ......................................................................
Patch Set 3: (3 inline comments) Agreed about the imagelocked of the VM. Will introduce a fix for that. Regarding to the concept, what do you think can be alternative. Disk with snapshot can't be floating. .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmCommand.java Line 32: private boolean hasImages; Yes, I'm thinking it can be more readable that way... Line 228: // If the are no disks the VM can be safely removed from the DB. 1. Lun disks are already filtered when I'm calling ImagesHandler.filterImageDisks 2. The problem is with disks which tasks were not initiated for them, it's not related if the task are finished with failure or sucess. Line 232: // If the VM still has images related to it, change their status to Illegal, so the user can remove the VM again. Why using the same transaction? It is the same transaction logic, we use to remove Lun disks as well... -- To view, visit http://gerrit.ovirt.org/5806 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic59918037a87a2c169c4410d297de81a03ab6848 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Ayal Baron <aba...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
