Maor Lipchuk has posted comments on this change. Change subject: engine:VM with remaining disks will not be deleted.(#822051) ......................................................................
Patch Set 5: (2 inline comments) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmCommand.java Line 32: private boolean hasImages; Thanks, will change. Line 224: // Get all disk images for VM (VM should not have any image disk associated with it). This is notion of tasks 1. If task failed we printing the VM succeeded to delete. - (Although deleted from ovirt but not from VDSM, VDSM should take care of this) 2. If task was not initiate we are printing the VM could not delete -- To view, visit http://gerrit.ovirt.org/5806 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic59918037a87a2c169c4410d297de81a03ab6848 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Ayal Baron <aba...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
