Maor Lipchuk has posted comments on this change. Change subject: engine:Delete image should roll forward.(#822051) ......................................................................
Patch Set 1: That is the approach, Same can be when task return failure, or when jboss will be killed in the middle (we are using rolling forward) I think the appropriate solution should be garbage collector in the VDSM. Although you are right that there is a use case that should be handled, when remove the first disk from DB and VDSM will be blocked, the operation will not start and that will leave the VM in the engine without the first disk. This will be fixed, thanks. I'm not sure I'm a fan of this solution. What if the images are removed from the VM and then JBoss is killed, before issuing a VDSM command? Will we just leave leftovers in VDSM for all eternity? -- To view, visit http://gerrit.ovirt.org/5806 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic59918037a87a2c169c4410d297de81a03ab6848 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Ayal Baron <aba...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
