Maor Lipchuk has posted comments on this change.

Change subject: engine:VM with remaining disks will not be deleted.(#822051)
......................................................................


Patch Set 5: (4 inline comments)

....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmCommand.java
Line 224:                     // Get all disk images for VM (VM should not have 
any image disk associated with it).
No

Line 233:                         imagesLeftInVm = true;
what ever

Line 237:                         }
Will use unlockVm with VmDynamic instead

Line 239:                     }
Might not be necessary

--
To view, visit http://gerrit.ovirt.org/5806
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic59918037a87a2c169c4410d297de81a03ab6848
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Ayal Baron <aba...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to