Shireesh Anjal has posted comments on this change. Change subject: core: adding service strategy for gluster integration ......................................................................
Patch Set 8: Looks good to me, but someone else must approve I can see that even when software capabilities are not met, the system updates the VDS as non-operational. If this understanding is correct, it might make sense to rename checkSoftwareCapabilities also to processSoftwareCapabilities and do the VDS update inside the VirtMonitoringStrategy. It will also mean that other monitoring strategies will be able to choose whether the host should be moved to non-operational or not when their software capabilities are not met, providing more flexibility. -- To view, visit http://gerrit.ovirt.org/2387 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5edc263dae23236015260d83a933e8a3a93e4523 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Livnat Peer <lp...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Shireesh Anjal <san...@redhat.com> Gerrit-Reviewer: Shireesh Anjal <shire...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
