Omer Frenkel has posted comments on this change.
Change subject: core: adding service strategy for gluster integration
......................................................................
Patch Set 10: (3 inline comments)
looks good, few minor things
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java
Line 300: if (_cpuFlagsChanged) {
the processHardwareCapabilities should be called regardless to _cpuFlagsChanged
- since might not be relevant for other implementations, maybe add new flag to
this class to determine if call to this method is needed?
we might want to deal with it later but i guess it will need to be changed.
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VirtMonitoringStrategy.java
Line 29: // If we can't test for those capabilities, we don't say they
don't exist (keeping the same behavior as today)
i wouldn't write in a comment: "(keeping the same ...)"
the sentence before is good enough as comment
....................................................
File
backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/VirtMonitoringStrategyTest.java
Line 26: vds.getDynamicData().setvm_count(1);
why not vds.setvm_count(1); ?
--
To view, visit http://gerrit.ovirt.org/2387
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5edc263dae23236015260d83a933e8a3a93e4523
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Oved Ourfali <oourf...@redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Livnat Peer <lp...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com>
Gerrit-Reviewer: Shireesh Anjal <san...@redhat.com>
Gerrit-Reviewer: Shireesh Anjal <shire...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
