Moti Asayag has posted comments on this change.
Change subject: core: adding service strategy for gluster integration
......................................................................
Patch Set 7: (3 inline comments)
....................................................
File
backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/VdsManagerTest.java
Line 64: public void mockConfig() {
you can use/extend org.ovirt.engine.core.bll.ConfigMocker to mock configuration
values.
Line 145: vds.setkvm_enabled(new Boolean(true));
use Boolean.TRUE instead
Line 147: vds.setkvm_enabled(new Boolean(false));
use Boolean.FALSE instead
--
To view, visit http://gerrit.ovirt.org/2387
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5edc263dae23236015260d83a933e8a3a93e4523
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Oved Ourfali <oourf...@redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Livnat Peer <lp...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com>
Gerrit-Reviewer: Shireesh Anjal <san...@redhat.com>
Gerrit-Reviewer: Shireesh Anjal <shire...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
