Shireesh Anjal has posted comments on this change. Change subject: core: adding service strategy for gluster integration ......................................................................
Patch Set 9: In MonitoringStrategy, why should processSoftwareCapabilities return boolean when processHardwareCapabilities doesn't? Also, a "process something" method returning false would logically indicate that the processing failed. So using that to indicate that the VDS status was not changed is not very appropriate. I think both methods should return "void". -- To view, visit http://gerrit.ovirt.org/2387 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5edc263dae23236015260d83a933e8a3a93e4523 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Livnat Peer <lp...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Shireesh Anjal <san...@redhat.com> Gerrit-Reviewer: Shireesh Anjal <shire...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
