Shireesh Anjal has posted comments on this change.
Change subject: core: adding service strategy for gluster integration
......................................................................
Patch Set 7: Looks good to me, but someone else must approve
(1 inline comment)
* MonitoringStrategy.java:
When it comes to testing hardware capabilities, we ask the strategy
"shouldTestSpecialHardwareCapabilities" ?
When it comes to testing software capabilities, we ask the strategy to actually
perform the tests ("testSpecialSoftwareCapabilities")
It will be good to make these two consistent.
* VdsManagerTest.java:
The tests look fine, but it looks like it contains tests for VdsManager,
MonitoringStrategyFactory, and VirtMonitoringStrategy all in one place. I
suggest to split this into the three separate test classes.
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/MonitoringStrategyFactory.java
Line 14: private static MonitoringStrategy glusterMonitoringStrategy = new
GlusterMonitoringStrategy();
Maybe this line can be kept commented as it is currently an unused variable?
--
To view, visit http://gerrit.ovirt.org/2387
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5edc263dae23236015260d83a933e8a3a93e4523
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Oved Ourfali <oourf...@redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Livnat Peer <lp...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com>
Gerrit-Reviewer: Shireesh Anjal <san...@redhat.com>
Gerrit-Reviewer: Shireesh Anjal <shire...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
