Oved Ourfali has posted comments on this change. Change subject: core: adding service strategy for gluster integration ......................................................................
Patch Set 8: changes in latest patch: 1. Split testers 2. Change method names to make them clearer. 3. Changes the shouldTest one to Process. We can't change it to test/check because the current event that does that doesn't only test, but performs updates on the VDS according to the result. 4. Changed the "new Boolean" to Boolean.TRUE/FALSE 5. Didn't use the ConfigMocker because it is in bll, and we can't add a dependency on that. One should consider moving it to a more general location, but it is out of scope to this patch. -- To view, visit http://gerrit.ovirt.org/2387 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5edc263dae23236015260d83a933e8a3a93e4523 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Livnat Peer <lp...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Shireesh Anjal <san...@redhat.com> Gerrit-Reviewer: Shireesh Anjal <shire...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
