Oved Ourfali has posted comments on this change. Change subject: DO NOT SUBMIT - wip - core: adding service policy for gluster integration ......................................................................
Patch Set 3: (1 inline comment) Juan - you are right about the name. Still waiting for Livnat to comment on that, as I wouldn't want to rename it twice :-) I thought of VdsServiceManagementPolicy which will contain VirtVdsServiceManagementPolicy and GlusterVdsServiceManagementPolicy I would happily call it Host instead of Vds, if core engine people will allow me to do so :-) .................................................... File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java Line 197: this.servicePolicy = servicePolicy; you're correct. Next patch set will address this. -- To view, visit http://gerrit.ovirt.org/2387 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5edc263dae23236015260d83a933e8a3a93e4523 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Livnat Peer <lp...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Shireesh Anjal <san...@redhat.com> Gerrit-Reviewer: Shireesh Anjal <shire...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
