Re: Review Request 128707: Add support for captive portals

> On Sept. 5, 2016, 3:47 p.m., Lamarque Souza wrote: > > kded/portalmonitor.cpp, line 50 > > <https://git.reviewboard.kde.org/r/128707/diff/4/?file=474728#file474728line50> > > > > I am wondering how hard this waill affect kde.org web server. This > >

Re: Review Request 128707: Add support for captive portals

DDoS attack-like effect on it. Maybe someone from sysadmin should evaluate this. - Lamarque Souza On Aug. 18, 2016, 12:47 p.m., Jan Grulich wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://g

Re: Review Request 128707: Add support for captive portals

> On Aug. 18, 2016, 12:37 p.m., Lamarque Souza wrote: > > kded/portalmonitor.cpp, line 44 > > <https://git.reviewboard.kde.org/r/128707/diff/3/?file=474715#file474715line44> > > > > You should delete m_view here in case this module is unloaded from

Re: Review Request 128707: Add support for captive portals

org/r/128707/#comment66357> #if WITH_WEBENGINE_SUPPORT - Lamarque Souza On Aug. 18, 2016, 12:47 p.m., Jan Grulich wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboar

Re: Review Request 128707: Add support for captive portals

ttps://git.reviewboard.kde.org/r/128707/ > --- > > (Updated Aug. 18, 2016, 11:42 a.m.) > > > Review request for Network Management, Plasma, KDE Usability, and Lamarque > Souza. > > > Bugs: 365417 > http://bugs.kde.org/show_bug.cgi?id=365417 > > > Repository: pl

Re: [Kde-hardware-devel] hail to the new plasma-pa maintainer

On Thu, Apr 14, 2016 at 9:02 AM, Sebastian Kügler wrote: > Hi all, > > David has been working tirelessly on plasma-pa, our pulseaudio volume > controller applet. Since by now, he understands the code much better than > me > (the current maintainer), it's only fair to transfer maintainership to hi

Re: Review Request 127263: Add Wireless Energy Saving action

> On March 3, 2016, 12:35 p.m., Lamarque Souza wrote: > > daemon/actions/bundled/wirelesspowersaving.cpp, line 49 > > <https://git.reviewboard.kde.org/r/127263/diff/1/?file=447897#file447897line49> > > > > This and the next two if are a bit strange. Shoul

Re: Review Request 127263: Add Wireless Energy Saving action

if are a bit strange. Shouldn't this be: if (m_lastWifiState != m_currentProfileDisableWifi) { - Lamarque Souza On March 3, 2016, 12:11 p.m., Jan Grulich wrote: > > --- > This is an automatically generated e-mail

Re: Review Request 126748: [Plasma-NM] Don't emit connection deactivated message on suspending

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126748/#review91598 --- Ship it! Ship It! - Lamarque Souza On Jan. 15, 2016, 3

Re: Review Request 126748: [Plasma-NM] Don't emit connection deactivated message on suspending

> On Jan. 15, 2016, 4:04 p.m., Lamarque Souza wrote: > > kded/notification.cpp, line 56 > > <https://git.reviewboard.kde.org/r/126748/diff/2/?file=430946#file430946line56> > > > > It would be safer to add an inhibit to guarantee onPrepareForSleep()

Re: Review Request 126748: [Plasma-NM] Don't emit connection deactivated message on suspending

knows? - Lamarque Souza On Jan. 15, 2016, 3:03 p.m., Kai Uwe Broulik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboar

Re: Review Request 125266: Authentication with certificates / Make MRU/MTU editable / Dialog fix

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125266/#review89632 --- Ship it! Ship It! - Lamarque Souza On Dec. 16, 2015, 10

Re: Review Request 125266: Authentication with certificates / Make MRU/MTU editable / Dialog fix

tps://git.reviewboard.kde.org/r/125266/#comment61392> Code style: the identation is wrong "case" should align vertically with "switch". Other than that the patch looks good to me. - Lamarque Souza On Dec. 16, 2015, 10

Re: Review Request 125266: Authentication with certificates / Make MRU/MTU editable / Dialog fix

> On Dec. 13, 2015, 10:45 p.m., René Fürst wrote: > > vpn/l2tp/l2tpwidget.cpp, line 183 > > <https://git.reviewboard.kde.org/r/125266/diff/3/?file=422014#file422014line183> > > > > That's actually not my code. I just indented it because it went into an

Re: Review Request 125266: Authentication with certificates / Make MRU/MTU editable / Dialog fix

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125266/#review89443 --- - Lamarque Souza On Dec. 13, 2015, 10:48 p.m., René Fürst

Re: Review Request 125266: Authentication with certificates / Make MRU/MTU editable / Dialog fix

> On Dec. 13, 2015, 10:45 p.m., René Fürst wrote: > > vpn/l2tp/l2tpwidget.cpp, line 183 > > > > > > That's actually not my code. I just indented it because it went into an > > if. Fixed it anyway. Do not do cod

Re: Review Request 125266: Authentication with certificates / Make MRU/MTU editable / Dialog fix

e. Take a look at OpenVpnSettingWidget::handleOnePasswordType() to see how to do that. vpn/l2tp/l2tpwidget.cpp (line 180) <https://git.reviewboard.kde.org/r/125266/#comment61207> This comment has no meaning, remove it. - Lamarque Souza On Dec. 13, 2015, 10:19

Re: Review Request 125266: Authentication with certificates / Make MRU/MTU editable / Dialog fix

Code style: if (...) { } vpn/l2tp/l2tpwidget.cpp (line 162) <https://git.reviewboard.kde.org/r/125266/#comment61177> Remove space. vpn/l2tp/l2tpwidget.cpp (line 265) <https://git.reviewboard.kde.org/r/125266/#comment61179> Code style: if (...) { } else {

Re: Review Request 126096: Fix memory leak in kscreen backend of libkscreen

xcb_randr_get_screen_resources_reply. Diffs - backends/xrandr/xrandrscreen.cpp 8df957e Diff: https://git.reviewboard.kde.org/r/126096/diff/ Testing --- No memory leak and everything still works. Thanks, Lamarque Souza ___ Plasma-devel mailing list Plasma

Re: Review Request 126096: Fix memory leak in kscreen backend of libkscreen

ot; used in XRandR::screenResources(). - Lamarque --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126096/#review88491 -------

Re: Review Request 126096: Fix memory leak in kscreen backend of libkscreen

/r/126096/diff/ Testing --- No memory leak and everything still works. Thanks, Lamarque Souza ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126096: Fix memory leak in kscreen backend of libkscreen

still works. Thanks, Lamarque Souza ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 124589: Add Disk Quota Plasmoid

> On Aug. 6, 2015, 2:12 p.m., Lamarque Souza wrote: > > applets/diskquota/plugin/DiskQuota.cpp, line 158 > > <https://git.reviewboard.kde.org/r/124589/diff/5/?file=389660#file389660line158> > > > > You should search for quota and filelight programs during

Re: Review Request 124589: Add Disk Quota Plasmoid

> On Aug. 6, 2015, 2:12 p.m., Lamarque Souza wrote: > > applets/diskquota/plugin/DiskQuota.cpp, line 158 > > <https://git.reviewboard.kde.org/r/124589/diff/5/?file=389660#file389660line158> > > > > You should search for quota and filelight programs during

Re: Review Request 124589: Add Disk Quota Plasmoid

t */) may be necessary. - Lamarque Souza On Aug. 3, 2015, 5:34 p.m., Dominik Haumann wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.revi

Re: Review Request 124589: Add Disk Quota Plasmoid

static_cast since maxQuota is int already. - Lamarque Souza On Aug. 2, 2015, 9:39 a.m., Dominik Haumann wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.revi

Re: Review Request 124485: Add missing traffic monitor

tem.qml (line 519) <https://git.reviewboard.kde.org/r/124485/#comment57318> so at least write the original file path you copied that from. - Lamarque Souza On July 27, 2015, 10:55 a.m., Jan Grulich wrote: > > --- > This

Re: Review Request 124314: Workaround for notifications stealing focus of the connect/disconnect button

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124314/#review82922 --- Ship it! Ship It! - Lamarque Souza On July 23, 2015, 3:12

Re: Review Request 124314: Workaround for notifications stealing focus of the connect/disconnect button

tionView.currentIndexVisibleButton = -1 > > } > > > > Maybe? So the button doesn't stay there indefinitely > > Lamarque Souza wrote: > +1 from me for this change > > Kai Uwe Broulik wrote: > Thinking about it, that probably exposes the same problem, because >

Re: Review Request 124314: Workaround for notifications stealing focus of the connect/disconnect button

> On July 14, 2015, 1:11 p.m., Lamarque Souza wrote: > > applet/contents/ui/PopupDialog.qml, line 68 > > <https://git.reviewboard.kde.org/r/124314/diff/1/?file=383993#file383993line68> > > > > The correct English for this is currentVisibleButtonIndex.

Re: Review Request 124314: Workaround for notifications stealing focus of the connect/disconnect button

tps://git.reviewboard.kde.org/r/124314/#comment56900> The correct English for this is currentVisibleButtonIndex. - Lamarque Souza On July 14, 2015, 7:43 a.m., Jan Grulich wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 124314: Workaround for notifications stealing focus of the connect/disconnect button

> On July 14, 2015, 8:29 a.m., Kai Uwe Broulik wrote: > > applet/contents/ui/ConnectionItem.qml, line 423 > > > > > > } else { > > connectionView.currentIndexVisibleButton = -1 > > } > > > >

Re: Review Request 102983: Added support for rfkill

il/test/bluedeviltest.cpp (line 121) <https://git.reviewboard.kde.org/r/102983/#comment56754> "RfkillSwitch not supported in this platform" - Lamarque Souza On July 11, 2015, 8:43 p.m., Rüdiger Sonderfeld wrote: > > ---

Re: [Kde-hardware-devel] solid bugzilla product marked obsolete

Hi all, Following the obsolete action, could someone mark "Network Management" product as obsolete too? It is related to old Plasma NM 0.9.0.x series, which is now unmaintained. Lamarque V. Souza KDE's Network Management maintainer http://planetkde.org/pt-br On Wed, Mar 11, 2015 at 7:57 PM, Al

Re: Review Request 122835: Make applet's tooltip visually more consistent with other applets

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122835/#review77077 --- Ship it! Ship It! - Lamarque Souza On March 5, 2015, 11

Re: Review Request 110476: Call KNotification::close() when notification is closed in the applet

quot; here. I still do not fully understand this comment, deleting a service before it finishes sounds like a bug to me. - Lamarque Souza On June 9, 2013, 1:11 p.m., Dan Vrátil wrote: > > --- > This is an automatically

Re: Review Request 110670: fixes for qml import paths order

g/r/110670/#comment24571> What is exactly the bug this patch is trying to solve? Is there any bug entry in bugzilla for it (or them)? - Lamarque Souza On May 27, 2013, 1:14 p.m., Oliver Henshaw wrote: > > --- > This is a