----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127263/#review93088 -----------------------------------------------------------
CMakeLists.txt (line 25) <https://git.reviewboard.kde.org/r/127263/#comment63472> I think BluezQt should be optional. Not everbody uses bluetooth in their computers, desktop pc for instance. daemon/actions/bundled/wirelesspowersaving.cpp (line 49) <https://git.reviewboard.kde.org/r/127263/#comment63471> This and the next two if are a bit strange. Shouldn't this be: if (m_lastWifiState != m_currentProfileDisableWifi) { - Lamarque Souza On March 3, 2016, 12:11 p.m., Jan Grulich wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127263/ > ----------------------------------------------------------- > > (Updated March 3, 2016, 12:11 p.m.) > > > Review request for Plasma, Solid and Kai Uwe Broulik. > > > Repository: powerdevil > > > Description > ------- > > This action adds an option to turn off wifi/wwan/bt once you switch profile > (e.g you unplugg the power cable and start running on battery). > > One more thing. Due to usage of NetworkManagerQt I had to add > add_definitions(-DQT_NO_KEYWORDS) into CMakeLists.txt like we do in > plasma-nm to avoid compilation error (thanks to NetworkManager) and replace > all keywords by their Qt equivalent (e.g signals ? Q_SIGNALS). > > > Diffs > ----- > > CMakeLists.txt e7fff17 > daemon/CMakeLists.txt bbfe191 > daemon/actions/bundled/CMakeLists.txt 45abea3 > daemon/actions/bundled/handlebuttonevents.h 5d602d7 > daemon/actions/bundled/handlebuttonevents.cpp 7e1d16e > daemon/actions/bundled/handlebuttoneventsconfig.cpp b1d4ef0 > > daemon/actions/bundled/org.kde.Solid.PowerManagement.Actions.WirelessPowerSaving.xml > PRE-CREATION > daemon/actions/bundled/powerdevilwirelesspowersavingaction.desktop > PRE-CREATION > daemon/actions/bundled/suspendsession.h d0fc78d > daemon/actions/bundled/wirelesspowersaving.h PRE-CREATION > daemon/actions/bundled/wirelesspowersaving.cpp PRE-CREATION > daemon/actions/bundled/wirelesspowersavingconfig.h PRE-CREATION > daemon/actions/bundled/wirelesspowersavingconfig.cpp PRE-CREATION > daemon/backends/upower/backlighthelper.h b5ce7dc > daemon/backends/upower/backlighthelper.cpp 58b82be > daemon/backends/upower/powerdevilupowerbackend.h 32f0ee4 > daemon/backends/upower/powerdevilupowerbackend.cpp 6133887 > daemon/backends/upower/udevqtclient.cpp 52b17f6 > daemon/kwinkscreenhelpereffect.h bc1c21b > daemon/kwinkscreenhelpereffect.cpp dec5d65 > daemon/powerdevilactionconfig.cpp 2565b0d > daemon/powerdevilactionpool.cpp 2091879 > daemon/powerdevilbackendinterface.cpp 7aadb01 > daemon/powerdevilcore.cpp f02d474 > daemon/powerdevilfdoconnector.cpp d9a3ee6 > daemon/powerdevilpolicyagent.cpp e0d1ec6 > daemon/powerdevilprofilegenerator.cpp cff3120 > kcmodule/activities/activitypage.cpp ec18dee > kcmodule/activities/activitywidget.cpp 5992a4d > kcmodule/common/actioneditwidget.cpp 216399c > kcmodule/global/GeneralPage.h a34d54f > kcmodule/global/GeneralPage.cpp b2d9767 > kcmodule/profiles/EditPage.h 4791017 > kcmodule/profiles/EditPage.cpp 30973b2 > > Diff: https://git.reviewboard.kde.org/r/127263/diff/ > > > Testing > ------- > > I did some basic testing like (un)plugging the power cable and checking > whether it applied the correct configuration. > > > Thanks, > > Jan Grulich > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
