> On Dec. 13, 2015, 10:45 p.m., René Fürst wrote: > > vpn/l2tp/l2tpwidget.cpp, line 183 > > <https://git.reviewboard.kde.org/r/125266/diff/3/?file=422014#file422014line183> > > > > That's actually not my code. I just indented it because it went into an > > if. Fixed it anyway.
Do not do code style only changes in code that do not belong to this patch. That makes reviewing more difficult for all of us that are reviewing this patch. - Lamarque ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125266/#review89437 ----------------------------------------------------------- On Dec. 13, 2015, 10:48 p.m., René Fürst wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125266/ > ----------------------------------------------------------- > > (Updated Dec. 13, 2015, 10:48 p.m.) > > > Review request for Network Management and Plasma. > > > Repository: plasma-nm > > > Description > ------- > > Authentication with certificates / Make MRU/MTU editable / Dialog fix > > > Diffs > ----- > > vpn/l2tp/l2tp.ui bf35d02 > vpn/l2tp/l2tpppp.ui 3c70165 > vpn/l2tp/l2tppppwidget.cpp ffe2c2b > vpn/l2tp/l2tpwidget.h a161b53 > vpn/l2tp/l2tpwidget.cpp a4ff42f > vpn/l2tp/nm-l2tp-service.h ac2ecc9 > > Diff: https://git.reviewboard.kde.org/r/125266/diff/ > > > Testing > ------- > > This patch contains 3 things: > 1) Add authentication with certificates > 2) Make MRU/MTU editable > 3) Fix an issue where PPP/Advanced settings were lost when the dialogs were > not opened > > The base for 1) and 2) was added to NetworkManager-l2tp here > https://github.com/frenetic1/NetworkManager-l2tp/commit/8103cf09e2cda19d701a48331eba069ff4c8e82c > > > Thanks, > > René Fürst > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
