----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125266/#review89436 -----------------------------------------------------------
vpn/l2tp/l2tpwidget.cpp (line 102) <https://git.reviewboard.kde.org/r/125266/#comment61205> Actually it should have been QLatin1String instead of QStringLiteral here. Sorry the wrong tip. vpn/l2tp/l2tpwidget.cpp (line 176) <https://git.reviewboard.kde.org/r/125266/#comment61206> Use switch intead of nested if's here. Take a look at OpenVpnSettingWidget::handleOnePasswordType() to see how to do that. vpn/l2tp/l2tpwidget.cpp (line 180) <https://git.reviewboard.kde.org/r/125266/#comment61207> This comment has no meaning, remove it. - Lamarque Souza On Dec. 13, 2015, 10:19 p.m., René Fürst wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125266/ > ----------------------------------------------------------- > > (Updated Dec. 13, 2015, 10:19 p.m.) > > > Review request for Network Management and Plasma. > > > Repository: plasma-nm > > > Description > ------- > > Authentication with certificates / Make MRU/MTU editable / Dialog fix > > > Diffs > ----- > > vpn/l2tp/l2tp.ui bf35d02 > vpn/l2tp/l2tpppp.ui 3c70165 > vpn/l2tp/l2tppppwidget.cpp ffe2c2b > vpn/l2tp/l2tpwidget.h a161b53 > vpn/l2tp/l2tpwidget.cpp a4ff42f > vpn/l2tp/nm-l2tp-service.h ac2ecc9 > > Diff: https://git.reviewboard.kde.org/r/125266/diff/ > > > Testing > ------- > > This patch contains 3 things: > 1) Add authentication with certificates > 2) Make MRU/MTU editable > 3) Fix an issue where PPP/Advanced settings were lost when the dialogs were > not opened > > The base for 1) and 2) was added to NetworkManager-l2tp here > https://github.com/frenetic1/NetworkManager-l2tp/commit/8103cf09e2cda19d701a48331eba069ff4c8e82c > > > Thanks, > > René Fürst > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
