----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124485/#review83041 -----------------------------------------------------------
applet/contents/ui/ConnectionItem.qml (line 306) <https://git.reviewboard.kde.org/r/124485/#comment57319> what's the update rate used here? I think it is still 1 second. The old Plasma NM used to use 2 seconds instead. Increasing the update time can also help with the update overhead. applet/contents/ui/ConnectionItem.qml (line 346) <https://git.reviewboard.kde.org/r/124485/#comment57321> I do not understand why returning when source name is found. Sorry for not looking at DataSource documentation for the answer but my laptop is malfunctioning. I am doing this review from my tablet. applet/contents/ui/ConnectionItem.qml (line 519) <https://git.reviewboard.kde.org/r/124485/#comment57318> so at least write the original file path you copied that from. - Lamarque Souza On July 27, 2015, 10:55 a.m., Jan Grulich wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124485/ > ----------------------------------------------------------- > > (Updated July 27, 2015, 10:55 a.m.) > > > Review request for Network Management, Plasma and KDE Usability. > > > Bugs: 333070 > http://bugs.kde.org/show_bug.cgi?id=333070 > > > Repository: plasma-nm > > > Description > ------- > > See summary. > > > Diffs > ----- > > applet/contents/ui/ConnectionItem.qml ff722a7 > > Diff: https://git.reviewboard.kde.org/r/124485/diff/ > > > Testing > ------- > >  > > > Thanks, > > Jan Grulich > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
