> On July 14, 2015, 8:29 a.m., Kai Uwe Broulik wrote: > > applet/contents/ui/ConnectionItem.qml, line 423 > > <https://git.reviewboard.kde.org/r/124314/diff/1/?file=383992#file383992line423> > > > > } else { > > connectionView.currentIndexVisibleButton = -1 > > } > > > > Maybe? So the button doesn't stay there indefinitely
+1 from me for this change - Lamarque ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124314/#review82483 ----------------------------------------------------------- On July 14, 2015, 7:43 a.m., Jan Grulich wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124314/ > ----------------------------------------------------------- > > (Updated July 14, 2015, 7:43 a.m.) > > > Review request for Network Management and Plasma. > > > Bugs: 348905 > http://bugs.kde.org/show_bug.cgi?id=348905 > > > Repository: plasma-nm > > > Description > ------- > > Previously the button was shown when item contained mouse cursor, but when a > notification appeared and you clicked on the button the "containsMouse" > property was changed to false and click on the button didn't have any effect. > Now I store which item has the connect/disconnect button visible and this is > not changed until you move mouse cursor to another item, thus when a > notification appears and you click on the button it works and the button > remains visible. > > > Diffs > ----- > > applet/contents/ui/ConnectionItem.qml 3fa93b5 > applet/contents/ui/PopupDialog.qml 2a0d352 > > Diff: https://git.reviewboard.kde.org/r/124314/diff/ > > > Testing > ------- > > > Thanks, > > Jan Grulich > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
