davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R242 Plasma Framework (Library)
BRANCH
rtl
REVISION DETAIL
https://phabricator.kde.org/D9126
To: mvourlakos, #plasma, davidedmundson
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, leslie
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D9158
To: subdiff, #plasma, davidedmundson
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abet
subdiff created this revision.
subdiff added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
Globals need to be constant in shader code for some GL ES versions. Otherwise
leads to non-compiling shader.
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:2bd71b5ab232: set default action when trash applet
activated (authored by mvourlakos).
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9133?vs=23343&id=23402
broulik accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R119 Plasma Desktop
BRANCH
trash
REVISION DETAIL
https://phabricator.kde.org/D9133
To: mvourlakos, #plasma, broulik
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
a
mart updated this revision to Diff 23397.
mart added a comment.
only toString once
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9124?vs=23328&id=23397
BRANCH
phab/killurlinterceptor
REVISION DETAIL
https://phabricator.kde.org/D912
mart added inline comments.
INLINE COMMENTS
> davidedmundson wrote in qmlobject.h:72
> The problem being solved is that QQmlObjectSharedEngine inherits QQmlObject
> that needs a constructor that doesn't do engine things
>
> It could be protected though.
what about a different ctor which does th
hein reopened this revision.
hein added a comment.
Sorry, accidental push. I'll revert and reopen this.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D9119
To: hein, #plasma, davidedmundson, broulik, mart
Cc: graesslin, plasma-devel, #frameworks,
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:15f470fafce3: Initialize scale factor to the last scale
factor set on any instance (authored by hein).
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:a570254e1aad: Don't update when the underlying
FrameSvg is repaint-blocked (authored by hein).
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D913
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R242 Plasma Framework (Library)
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D9138
To: hein, #plasma, davidedmundson, mart
Cc: anthonyfieroni, plasma-devel, #frameworks, ZrenBot
hein added inline comments.
INLINE COMMENTS
> anthonyfieroni wrote in framesvgitem.cpp:463
> It doesn't have d-pointer
(I did a git reset and then rewrote the patch, that's how this happened ...)
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D9138
hein added a comment.
I accidentally pushed this, but given Kai's earlier comment I think this was
OK. Please double-check if necessary.
It's not my day with command line tools I think :-)
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D9122
To: hein, #p
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:194483b05a75: Save an object per panel applet (authored
by hein).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D9152?vs=23381&id=23386#toc
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST
davidedmundson added inline comments.
INLINE COMMENTS
> mart wrote in qmlobject.h:72
> this shouldn't be necessary?
>
> qmoobject will do things engine-wise, the qmlsharedengine subclass will
> always do things context-wise without new public constructors?
The problem being solved is that QQml
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:1a45aaf94893: Implement QQmlParserStatus in FolderModel
(authored by hein).
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9122?vs=23323&id=23385
REVISION D
mart accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R119 Plasma Desktop
BRANCH
origin-master (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D9150
To: davidedmundson, #plasma, mart
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, al
hein added a comment.
Will add a comment, the sizing thing isn't a problem because the Loader
resizes the BusyIndicator.
REPOSITORY
R119 Plasma Desktop
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D9152
To: hein, #plasma, mart, davidedmundson
Cc: davidedmundson, plasma-d
mart accepted this revision.
REPOSITORY
R119 Plasma Desktop
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D9152
To: hein, #plasma, mart, davidedmundson
Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, mart
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R119 Plasma Desktop
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D9152
To: hein, #plasma, mart, davidedmundson
Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai,
davidedmundson added a comment.
In general +1.
A comment at the top of Loader making it clear it's not a loader for the
applet would help.
INLINE COMMENTS
> main.qml:292
> +active: applet && applet.busy
> +sourceComponent: PlasmaComponents.BusyIndicator {}
> +
In t
mart requested changes to this revision.
mart added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> qmlobject.h:72
> + */
> +enum class SetupFlag {
> +Engine = 1<<0, ///< call setupEngine() on it
this shouldn't be necessary?
qmoobject will do th
hein created this revision.
hein added reviewers: Plasma, mart.
Restricted Application added a project: Plasma.
REVISION SUMMARY
Instead of Item { Loader {} } just make the applet
container the Loader. Also saves some prop bindings
for sizing and centering the BusyIndicator, which
still ap
adridg abandoned this revision.
adridg added a comment.
Careful use of -platform minimal allows running the tool with no changes to
the code or kcm.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D9149
To: adridg, #plasma, mart
Cc: apol, plasma-devel, ZrenBot
mart added a comment.
nitpick but should be fine
INLINE COMMENTS
> apol wrote in krdb.cpp:141
> Are you sure this builds? `primaryScreen` isn't static.
>
> I'd use `qGuiApp->primaryScreen()`.
is indeeed a static: QGuiApplication::primaryScreen() should be fine
REPOSITORY
R119 Plasma Desk
davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
It was added for when FolderView did some low level GL stuff to fetch an
image for thumbnails
apol added inline comments.
INLINE COMMENTS
> krdb.cpp:141
> + unsigned int pixmapDepth = 0;
> + if (QApplication::primaryScreen() != nullptr)
> +pixmapDepth = QPixmap::defaultDepth();
Are you sure this builds? `primaryScreen` isn't static.
I'd use `qGuiApp->primaryScreen()`.
> lnftool.c
This revision was automatically updated to reflect the committed changes.
Closed by commit R108:fe9664fd8469: Use the new ECMQMLModules to specify all of
KWin's runtime dependencies (authored by graesslin).
Restricted Application edited projects, added Plasma; removed KWin.
CHANGED PRIOR TO COMMI
adridg added a reviewer: mart.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D9149
To: adridg, #plasma, mart
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol, mart
adridg created this revision.
adridg added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
- Switch to QCoreApplication
- Check for availability of a primary screen before querying pixmap depth; if
t
graesslin added a comment.
Restricted Application edited projects, added Plasma; removed KWin.
ping
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D8956
To: graesslin, #plasma, #kwin
Cc: plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, a
hein added subscribers: mart, hein.
hein added a comment.
Looks good to me, but @mart needs to have a look too.
REPOSITORY
R296 KDeclarative
REVISION DETAIL
https://phabricator.kde.org/D9141
To: broulik, #plasma
Cc: hein, mart, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai,
broulik created this revision.
broulik added a reviewer: Plasma.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY
`setupBindings` is called for every `QmlObject` created and installs various
bits on t
bshah added a comment.
Please make same change on startplasma script which is used by wayland
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D9134
To: apol, #plasma, hein
Cc: bshah, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg,
apol edited the test plan for this revision.
REPOSITORY
R120 Plasma Workspace
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D9134
To: apol, #plasma, hein
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol, mart
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:d90c63ac8fe5: Remove blocking qtpaths call at boot
(authored by apol).
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9134?vs=23358&id=23359
REVISION DETA
apol updated this revision to Diff 23358.
apol added a comment.
Use the right path
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9134?vs=23357&id=23358
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D9134
AFFECTED FILES
startkd
hein accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R120 Plasma Workspace
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D9134
To: apol, #plasma, hein
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, se
apol updated this revision to Diff 23357.
apol added a comment.
Use the right variable and place
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9134?vs=23345&id=23357
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D9134
AFFECTED F
This revision was automatically updated to reflect the committed changes.
Closed by commit R108:545dda720870: [PaintClipper::Iterator] Operate on QRegion
instead of QVector of rects (authored by broulik).
Restricted Application edited projects, added KWin; removed Plasma.
REPOSITORY
R108 KWin
hein updated this revision to Diff 23354.
hein added a comment.
Fix code
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9138?vs=23351&id=23354
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D9138
AFFECTED FILES
src/dec
anthonyfieroni added inline comments.
INLINE COMMENTS
> framesvgitem.cpp:463
> {
> +if (d->m_frameSvg->isRepaintBlocked()) {
> +return;
It doesn't have d-pointer
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D9138
To: hein, #plasma, da
hein created this revision.
hein added reviewers: Plasma, davidedmundson, mart.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
When the component completes `FrameSvg::setRepaintBlocked(false)`
is called, which
graesslin accepted this revision.
This revision is now accepted and ready to land.
Restricted Application edited projects, added Plasma; removed KWin.
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D9135
To: broulik, #plasma, graesslin
Cc: plasma-devel, kwin, #kwin, ZrenBot
hein added a comment.
So I worked out why this happens. We have API like this:
SvgItem {
svg: Svg { imagePath: "..." }
}
Without my patch, `Svg` is instanciated with a scale factor of 1.0 always.
Then `setImagePath` is called on it first. Then `SvgItem::setSvg` is called
graesslin created this revision.
graesslin added reviewers: Frameworks, Plasma, KWin.
Restricted Application added projects: Plasma on Wayland, Frameworks.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
The main difference compared to version 2 is additional drag and d
apol added a comment.
QScopedPointer won't be checking if the object has been destroyed. Are you
sure it will never happen?
If so, +1.
REPOSITORY
R114 Plasma Addons
REVISION DETAIL
https://phabricator.kde.org/D9131
To: anthonyfieroni, davidedmundson, broulik
Cc: apol, plasma-devel, Zr
apol added a comment.
Wow that's a lot of code gone!
INLINE COMMENTS
> packageurlinterceptor.cpp:95
>
> -if (d->forcePlasmaStyle &&
> path.path().contains(QLatin1String("Controls.2/org.kde.desktop/"))) {
> -return
> QUrl::fromLocalFile(path.path().replace(QLatin1String("Contro
broulik created this revision.
broulik added a reviewer: Plasma.
Restricted Application added a project: KWin.
Restricted Application added subscribers: KWin, kwin, plasma-devel.
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D9135
AFFECTED FILES
libkwineffects/kwineffect
apol created this revision.
apol added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
We are just looking for files in .config and we already know where that is
REPOSITORY
R120 Plasma Workspace
BRA
mvourlakos created this revision.
mvourlakos added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
--provide a default action to be executed when
the trash applet is activated
TEST PLAN
--trigger t
davidedmundson abandoned this revision.
davidedmundson added a comment.
Not particularly convinced, but will drop this for lock screen.
Might revisit that if/when TextInput improves.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D9040
To: davidedmundson,
anthonyfieroni created this revision.
anthonyfieroni added reviewers: davidedmundson, broulik.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
TEST PLAN
When DownloadDialog is not destroyed KNS3 engine not store registry of
installed/upgr
anthonyfieroni created this revision.
anthonyfieroni added reviewers: davidedmundson, broulik.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
CCBUG: 355464
TEST PLAN
When DownloadDialog is not destroyed KNS3 engine not
mvourlakos created this revision.
mvourlakos added a reviewer: Plasma.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY
--align selected text correctly for
PlasmaComponents2.ComboBox taking into acco
mart abandoned this revision.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D9113
To: mart, #plasma
Cc: davidedmundson, apol, plasma-devel, #frameworks, ZrenBot, progwolff,
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart
mart created this revision.
mart added a reviewer: Plasma.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY
minimize file access during url rewrite
we still need it for accessing stuff under code/
hein added a comment.
Sorry for the noise.
This is now ready from my end, except for this build warning:
AutoMoc warning:
"/home/eike/devel/src/kde/workspace/plasma-desktop/kcms/launch/launchfeedback.cpp"
The file includes the moc file "launchfeedback.moc", but does not c
hein updated this revision to Diff 23326.
hein added a comment.
Try to fix diff
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8911?vs=23325&id=23326
BRANCH
arcpatch-D8911
REVISION DETAIL
https://phabricator.kde.org/D8911
AFFECTED FILES
kcms
hein updated this revision to Diff 23327.
hein added a comment.
Try again
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8911?vs=23326&id=23327
BRANCH
fixthediff
REVISION DETAIL
https://phabricator.kde.org/D8911
AFFECTED FILES
kcms/launch/CM
hein added a comment.
Argh, I have no idea what happened to the diff ...
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D8911
To: hein, #plasma, mart, abetts
Cc: anthonyfieroni, mmustac, ngraham, davidedmundson, broulik, plasma-devel,
ZrenBot, progwolff, lesl
hein updated this revision to Diff 23325.
hein added a comment.
- Port to SimpleKCM as base item
- Fix a crash
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8911?vs=22828&id=23325
BRANCH
arcpatch-D8911
REVISION DETAIL
https://phabricator.kde
mart created this revision.
mart added a reviewer: Plasma.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY
to minimize metadata lookups, pass the kpackage created in pluginloader
to the applet itsel
hein added inline comments.
INLINE COMMENTS
> anthonyfieroni wrote in main.qml:30-39
> My personal note is not mandatory but this piece of code can be seen 2 times
> in C++ part and 1 in QML. Can we add it on C++ part and called here too.
I hear you, but IMHO it's not really worth it to get inv
hein updated this revision to Diff 23323.
hein added a comment.
Add interface
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9122?vs=23321&id=23323
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D9122
AFFECTED FILES
containments/d
broulik added a comment.
+1
INLINE COMMENTS
> foldermodel.h:79
> {
> Q_OBJECT
>
Add `Q_INTERFACES(QQmlParserStatus)`
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D9122
To: hein, #plasma, broulik
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, al
hein updated this revision to Diff 23321.
hein added a comment.
Remove a stray qDebug line.
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9122?vs=23320&id=23321
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D9122
AFFECTED FILES
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:ab8915bc12b4: [FrameSvgItem] Don't create
unneccessary nodes (authored by broulik).
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9121?vs=23319&
hein created this revision.
hein added reviewers: Plasma, broulik.
Restricted Application added a project: Plasma.
REVISION SUMMARY
This saves four calls to `invalidateFilter()` during startup with
default config. With non-default config it will save various
calls to `invalidate()` and `inva
davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.
Edit: I was wrong.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D9121
To: broulik, #plasma, davidedmundson
Cc: davidedmundson,
davidedmundson added a comment.
Are you sure you've checked enabled borders changing at runtime?
if it changes oldNode is still set, so we don't go through this again.
We just (and this could be changed) update the nodes in that case.
REPOSITORY
R242 Plasma Framework (Library)
REV
broulik created this revision.
broulik added a reviewer: Plasma.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY
If a border isn't enabled there's no point in creating a node for it
TEST PLAN
Borde
This revision was automatically updated to reflect the committed changes.
Closed by commit R296:09ad7c2e2dad: Qml controls for kcm creation (authored by
mart).
REPOSITORY
R296 KDeclarative
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8982?vs=22996&id=23318
REVISION DETAIL
https:
This revision was automatically updated to reflect the committed changes.
Closed by commit R169:1a136c28f44c: FormLayout (authored by mart).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D8641?vs=23092&id=23317#toc
REPOSITORY
R169 Kirigami
CHANGES SINCE LAST UPDATE
https://phabricato
hein added a comment.
In https://phabricator.kde.org/D9119#174887, @davidedmundson wrote:
> how is this one method different from setSize setColorGroup
setContainsMultipleImages setUseSystemColors etc.?
Most of those don't show up at 2% during my plasmashell startup. The scale
f
davidedmundson added a comment.
how is this one method different from setSize setColorGroup
setContainsMultipleImages setUseSystemColors etc.?
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D9119
To: hein, #plasma, davidedmundson, broulik, mart
C
hein added a comment.
Personally, I disagree it's hack. It's just defensively written: It makes
sure users of the Svg API don't need to understand the order in which they need
to call setScaleFactor and setImagePath for good performance. For something
performance-critical I'd prefer not to h
This revision was automatically updated to reflect the committed changes.
Closed by commit R31:f0709ccc26c3: [Breeze window decoration] Don't
repaint title bar if not damaged (authored by broulik).
REPOSITORY
R31 Breeze
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9114?vs=23298&id=
davidedmundson added a comment.
Please push as two separate things.
The applet part looks fine aside from docs.
UrlInterceptor.
IMHO it might be worth a release that continues onwards after the reg exp (so
less performance benefits) and prints a warning if we end up i
broulik edited the summary of this revision.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D4362
To: broulik, #plasma
Cc: mart, davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff,
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apo
broulik updated this revision to Diff 23315.
broulik retitled this revision from "RFC: [AppletQuickItem] Cache QQmlComponent
used for settings QtQuick Controls 1 style" to "[AppletQuickItem] Only set
QtQuick Controls 1 style once per engine".
broulik edited the summary of this revision.
broulik e
apol added a comment.
Otherwise LGTM.
INLINE COMMENTS
> packageurlinterceptor.cpp:99
> //qDebug() << "Intercepted URL:" << path << type;
> +if
> (path.toString().contains(QRegularExpression(QLatin1String("ui/.*\.js" {
> +QString rewritten =
> path.toString().replace(QRe
hpereiradacosta accepted this revision.
REPOSITORY
R31 Breeze
REVISION DETAIL
https://phabricator.kde.org/D9114
To: broulik, #plasma, hpereiradacosta, graesslin, davidedmundson
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol, mart
graesslin added a comment.
I agree with David that this is a hack. Also I think it will fail for multi
screen with different dpi.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D9119
To: hein, #plasma, davidedmundson, broulik, mart
Cc: graesslin,
graesslin accepted this revision.
REPOSITORY
R31 Breeze
REVISION DETAIL
https://phabricator.kde.org/D9114
To: broulik, #plasma, hpereiradacosta, graesslin, davidedmundson
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol, mart
85 matches
Mail list logo
