davidedmundson added inline comments. INLINE COMMENTS
> mart wrote in qmlobject.h:72 > this shouldn't be necessary? > > qmoobject will do things engine-wise, the qmlsharedengine subclass will > always do things context-wise without new public constructors? The problem being solved is that QQmlObjectSharedEngine inherits QQmlObject that needs a constructor that doesn't do engine things It could be protected though. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D9141 To: broulik, #plasma, mart Cc: davidedmundson, hein, mart, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol