apol added inline comments.
INLINE COMMENTS
> krdb.cpp:141
> + unsigned int pixmapDepth = 0;
> + if (QApplication::primaryScreen() != nullptr)
> + pixmapDepth = QPixmap::defaultDepth();
Are you sure this builds? `primaryScreen` isn't static.
I'd use `qGuiApp->primaryScreen()`.
> lnftool.cpp:37
> {
> - QApplication app(argc, argv);
> + QCoreApplication app(argc, argv);
>
Is this the same binary as above? If so, it should be `QGuiApplication` at
least.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D9149
To: adridg, #plasma, mart
Cc: apol, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, mart
