apol added a comment.
Otherwise LGTM.
INLINE COMMENTS
> packageurlinterceptor.cpp:99
> //qDebug() << "Intercepted URL:" << path << type;
> + if
> (path.toString().contains(QRegularExpression(QLatin1String("ui/.*\.js")))) {
> + QString rewritten =
> path.toString().replace(QRegularExpression(QLatin1String("ui/(.*)\.js")),
> QLatin1String("code/\\1.js"));
Move the QRegularExpression into a variable and reuse.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D9113
To: mart, #plasma
Cc: apol, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai,
ali-mohamed, jensreuterberg, abetts, sebas, mart
