mart requested changes to this revision. mart added inline comments. This revision now requires changes to proceed.
INLINE COMMENTS > qmlobject.h:72 > + */ > + enum class SetupFlag { > + Engine = 1<<0, ///< call setupEngine() on it this shouldn't be necessary? qmoobject will do things engine-wise, the qmlsharedengine subclass will always do things context-wise without new public constructors? REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D9141 To: broulik, #plasma, mart Cc: hein, mart, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol